Re: [PATCH 4/5] Powerpc/hw-breakpoint: Optimize disable path

On 6/18/19 12:01 PM, Christophe Leroy wrote:

quoted

diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
index f002d2ffff86..265fac9fb3a4 100644
--- a/arch/powerpc/kernel/process.c
+++ b/arch/powerpc/kernel/process.c

@@ -793,10 +793,22 @@ static inline int set_dabr(struct arch_hw_breakpoint *brk)

      return __set_dabr(dabr, dabrx);
  }
  +static int disable_dawr(void)
+{
+    if (ppc_md.set_dawr)
+        return ppc_md.set_dawr(0, 0);
+
+    mtspr(SPRN_DAWRX, 0);

And SPRN_DAWR ?

Setting DAWRx with 0 should be enough to disable the breakpoint.