Re: [PATCH 1/5] Powerpc/hw-breakpoint: Replace stale do_dabr() with do_break()
From: Christophe Leroy <hidden>
Date: 2019-06-18 06:50:49
Also in:
lkml
The subject text should mention you are changing comments. Here it suggests you are changing code text. Le 18/06/2019 à 06:27, Ravi Bangoria a écrit :
do_dabr() was renamed with do_break() long ago. But I still see some comments mentioning do_dabr(). Replace it.
s/Replace it/Replace them/ Christophe
quoted hunk ↗ jump to hunk
Signed-off-by: Ravi Bangoria <redacted> --- arch/powerpc/kernel/hw_breakpoint.c | 2 +- arch/powerpc/kernel/ptrace.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)diff --git a/arch/powerpc/kernel/hw_breakpoint.c b/arch/powerpc/kernel/hw_breakpoint.c index a293a53b4365..1908e4fcc132 100644 --- a/arch/powerpc/kernel/hw_breakpoint.c +++ b/arch/powerpc/kernel/hw_breakpoint.c@@ -232,7 +232,7 @@ int hw_breakpoint_handler(struct die_args *args) * Return early after invoking user-callback function without restoring * DABR if the breakpoint is from ptrace which always operates in * one-shot mode. The ptrace-ed process will receive the SIGTRAP signal - * generated in do_dabr(). + * generated in do_break(). */ if (bp->overflow_handler == ptrace_triggered) { perf_bp_event(bp, regs);diff --git a/arch/powerpc/kernel/ptrace.c b/arch/powerpc/kernel/ptrace.c index 684b0b315c32..44b823e5e8c8 100644 --- a/arch/powerpc/kernel/ptrace.c +++ b/arch/powerpc/kernel/ptrace.c@@ -2373,7 +2373,7 @@ void ptrace_triggered(struct perf_event *bp, /* * Disable the breakpoint request here since ptrace has defined a * one-shot behaviour for breakpoint exceptions in PPC64. - * The SIGTRAP signal is generated automatically for us in do_dabr(). + * The SIGTRAP signal is generated automatically for us in do_break(). * We don't have to do anything about that here */ attr = bp->attr;