Thread (8 messages) 8 messages, 3 authors, 2019-01-24

Re: [PATCH v2 2/3] powerpc: Show PAGE_SIZE in __die() output

flat view

From: Christophe Leroy <hidden>
Date: 2019-01-10 13:44:31


Le 10/01/2019 à 12:57, Michael Ellerman a écrit :
The page size the kernel is built with is useful info when debugging a
crash, so add it to the output in __die().

Result looks like eg:

   kernel BUG at drivers/misc/lkdtm/bugs.c:63!
   Oops: Exception in kernel mode, sig: 5 [#1]
   LE PAGE_SIZE=64K SMP NR_CPUS=2048 NUMA pSeries
   Modules linked in: vmx_crypto kvm binfmt_misc ip_tables

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Reviewed-by: Christophe Leroy <redacted>

quoted hunk ↗ jump to hunk
---
  arch/powerpc/kernel/traps.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

v2: Adapt to single printk.
diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c
index 164fc92895be..a872c64618ad 100644
--- a/arch/powerpc/kernel/traps.c
+++ b/arch/powerpc/kernel/traps.c
@@ -257,8 +257,9 @@ static int __die(const char *str, struct pt_regs *regs, long err)
  {
  	printk("Oops: %s, sig: %ld [#%d]\n", str, err, ++die_counter);
  
-	printk("%s %s%s%s%s%s %s\n",
+	printk("%s PAGE_SIZE=%luK%s%s%s%s%s %s\n",
  	       IS_ENABLED(CONFIG_CPU_LITTLE_ENDIAN) ? "LE" : "BE",
+	       PAGE_SIZE / 1024,
  	       IS_ENABLED(CONFIG_PREEMPT) ? " PREEMPT" : "",
  	       IS_ENABLED(CONFIG_SMP) ? " SMP" : "",
  	       IS_ENABLED(CONFIG_SMP) ? (" NR_CPUS=" __stringify(NR_CPUS)) : "",
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help