Re: [PATCH 13/36] dt-bindings: arm: Convert PMU binding to json-schema

From
Robin Murphy <robin.murphy@arm.com>
Date
2018-11-08 15:54:39
Also in
linux-arm-kernel, linux-devicetree, lkml
Reply to
Rob Herring, 2018-11-01
On 01/11/2018 19:32, Rob Herring wrote:
On Tue, Oct 9, 2018 at 6:57 AM Will Deacon [off-list ref] wrote:
quoted
Hi Rob,

On Fri, Oct 05, 2018 at 11:58:25AM -0500, Rob Herring wrote:
quoted
Convert ARM PMU binding to DT schema format using json-schema.

Cc: Will Deacon <redacted>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: <redacted>
Cc: <redacted>
Signed-off-by: Rob Herring <robh@kernel.org>
---
  Documentation/devicetree/bindings/arm/pmu.txt | 70 --------------
  .../devicetree/bindings/arm/pmu.yaml          | 96 +++++++++++++++++++
  2 files changed, 96 insertions(+), 70 deletions(-)
  delete mode 100644 Documentation/devicetree/bindings/arm/pmu.txt
  create mode 100644 Documentation/devicetree/bindings/arm/pmu.yaml
[...]
quoted
-- interrupts : 1 combined interrupt or 1 per core. If the interrupt is a per-cpu
-               interrupt (PPI) then 1 interrupt should be specified.
[...]
quoted
+  interrupts:
+    oneOf:
+      - maxItems: 1
+      - minItems: 2
+        maxItems: 8
+        description: 1 interrupt per core.
+
+  interrupts-extended:
+    $ref: '#/properties/interrupts'
This seems like a semantic different between the two representations, or am
I missing something here? Specifically, both the introduction of
interrupts-extended and also dropping any mention of using a single per-cpu
interrupt (the single combined case is no longer support by Linux; not sure
if you want to keep it in the binding).
In regards to no support for the single combined interrupt, it looks
like Marvell Armada SoCs at least (armada-375 is what I'm looking at)
have only a single interrupt. Though the interrupt gets routed to MPIC
which then has a GIC PPI. So it isn't supported or happens to work
still since it is a PPI?
Well, the description of the MPIC in the Armada XP functional spec says:

"Interrupt sources ID0–ID28 are private events per CPU. Thus, each processor has a different set of events map interrupts ID0–ID28."

Odd grammar aside, that would seem to imply that <&mpic 3> is a per-cpu interrupt itself, thus AFAICS so long as it's cascaded to a GIC PPI and not an SPI then there's no issue there.

Robin.
Thread (79 messages) 79 messages, 15 authors, last reply 2018-12-03
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help