Thread (79 messages) 79 messages, 15 authors, 2018-12-03

Re: [PATCH 12/36] dt-bindings: arm: Convert cpu binding to json-schema

From: Will Deacon <hidden>
Date: 2018-12-03 12:40:35
Also in: linux-arm-kernel, linux-devicetree, linux-mediatek, lkml

On Fri, Nov 30, 2018 at 12:00:05PM -0600, Rob Herring wrote:
On Thu, Nov 8, 2018 at 2:49 AM Michal Simek [off-list ref] wrote:
quoted
Hi Rob,

On 05. 10. 18 18:58, Rob Herring wrote:
quoted
Convert ARM CPU binding to DT schema format using json-schema.

Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: devicetree@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-mediatek@lists.infradead.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/arm/cpus.txt          | 490 -----------------
 .../devicetree/bindings/arm/cpus.yaml         | 503 ++++++++++++++++++
 2 files changed, 503 insertions(+), 490 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/arm/cpus.txt
 create mode 100644 Documentation/devicetree/bindings/arm/cpus.yaml
[...]
quoted
I have take a look at xilinx part of this and try to build it for arm64
platforms and I see errors coming from this cpu description.
/root/linux/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dt.yaml:
cpu@0:compatible: ['arm,cortex-a53', 'arm,armv8'] is too long
/root/linux/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dt.yaml:
cpu@0:compatible: Additional items are not allowed ('arm,armv8' was
unexpected)
Thanks for actually giving this a spin!
quoted
Based on grep this is used in a lot of places
compatible = "arm,cortex-a53", "arm,armv8";

Should this be moved to just simple?
compatible = "arm,cortex-a53";
I'd normally go with the majority which would be to keep it. However,
'arm,armv8' is of questionable value, isn't actually documented, and
doesn't exist for any other version of the architecture. So we should
kill it IMO.
I'd prefer to keep it around, since that's what's used to describe the CPUs
on the fastmodel iirc.

Will
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help