Re: [PATCH v2] powerpc: Avoid code patching freed init sections

On Thu, 2018-09-13 at 07:38 +0200, Christophe LEROY wrote:

=20
Le 13/09/2018 =C3=A0 03:21, Tyrel Datwyler a =C3=A9crit :

quoted

On 09/12/2018 05:36 PM, Michael Neuling wrote:

quoted

=20

quoted

=20

quoted

+			(unsigned long)patch_addr);

=20
Please align second line as per Codying style.

=20
Sorry I can't see what's wrong. You're (or Cody :-P) going to have to
spell it
this out for me...

=20
I suspect that the suggestion is the opening parenthesis of "(unsigned
long)" should sit directly under the "K" of "KERN_DEBUG". I'm pretty su=

re

quoted

Documentation/process/coding-style.rst is very adamant that all identat=

ion

quoted

is always 8 characters and spaces should never be used, but there still
seems to be a lot of places/suggestions that argument lists that spill =

over

quoted

multiple lines should be space indented to align with the very first
argument at the top level. So, I guess I'm not sure what the desire is =

here.

quoted

Although moving to pr_debug might fit it to a single line anyways. ;)

=20
It is exactly that, as reported by checkpatch, look at=20
https://patchwork.ozlabs.org/patch/968850/

Sweet... looks like v3 is clean

https://patchwork.ozlabs.org/patch/969241/

Mikey