Re: [PATCH v2] powerpc: Avoid code patching freed init sections
From: Christophe LEROY <hidden>
Date: 2018-09-13 05:38:26
Le 13/09/2018 à 03:21, Tyrel Datwyler a écrit :
On 09/12/2018 05:36 PM, Michael Neuling wrote:quoted
quoted
quoted
+ (unsigned long)patch_addr);Please align second line as per Codying style.Sorry I can't see what's wrong. You're (or Cody :-P) going to have to spell it this out for me...I suspect that the suggestion is the opening parenthesis of "(unsigned long)" should sit directly under the "K" of "KERN_DEBUG". I'm pretty sure Documentation/process/coding-style.rst is very adamant that all identation is always 8 characters and spaces should never be used, but there still seems to be a lot of places/suggestions that argument lists that spill over multiple lines should be space indented to align with the very first argument at the top level. So, I guess I'm not sure what the desire is here. Although moving to pr_debug might fit it to a single line anyways. ;)
It is exactly that, as reported by checkpatch, look at https://patchwork.ozlabs.org/patch/968850/ Christophe