Re: [PATCH 5/5] arm64: dts: add LX2160ARDB board support

On Thu, Aug 23, 2018 at 10:08 AM Vabhav Sharma [off-list ref] wrote:

[...]

quoted

quoted

+               i2c@3 {
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <0x3>;
+
+                       sa56004@4c {

temperature-sensor@4c

Ok, temperature-sensor-1@4c

No, that's not what I said. You don't need the '-1' because the
unit-address makes the node name unique. Node names are supposed to be
generic based on the class/type of device. See the DT spec.

quoted

quoted

+                               compatible = "nxp,sa56004";
+                               reg = <0x4c>;
+                       };
+
+                       sa56004@4d {

Ok,temperature-sensor-2@4d

quoted

quoted

+                               compatible = "nxp,sa56004";
+                               reg = <0x4d>;
+                       };
+               };
+       };
+};
+
+&i2c4 {
+       status = "okay";
+
+       rtc@51 {
+               compatible = "nxp,pcf2129";
+               reg = <0x51>;
+               // IRQ10_B
+               interrupts = <0 150 0x4>;
+               };
+
+};
+
+&usb0 {
+       status = "okay";
+};
+
+&usb1 {
+       status = "okay";
+};
+
+&crypto {
+       status = "okay";
+};
--
2.7.4