Thread (4 messages) flat view 4 messages, 4 authors, 2018-06-05

Re: [PATCH -next] ocxl: Fix missing unlock on error in afu_ioctl_enable_p9_wait()

From: Frederic Barrat <hidden>
Date: 2018-06-05 12:57:11
Also in: kernel-janitors, lkml


Le 05/06/2018 à 11:16, Wei Yongjun a écrit :
quoted hunk ↗ jump to hunk
Add the missing unlock before return from function
afu_ioctl_enable_p9_wait() in the error handling case.

Fixes: e948e06fc63a ("ocxl: Expose the thread_id needed for wait on POWER9")
Signed-off-by: Wei Yongjun <redacted>
---
  drivers/misc/ocxl/file.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/misc/ocxl/file.c b/drivers/misc/ocxl/file.c
index 33ae46c..e6a6074 100644
--- a/drivers/misc/ocxl/file.c
+++ b/drivers/misc/ocxl/file.c
@@ -139,8 +139,10 @@ static long afu_ioctl_enable_p9_wait(struct ocxl_context *ctx,
  		// Locks both status & tidr
  		mutex_lock(&ctx->status_mutex);
  		if (!ctx->tidr) {
-			if (set_thread_tidr(current))
+			if (set_thread_tidr(current)) {
+				mutex_unlock(&ctx->status_mutex);
  				return -ENOENT;
+			}
O_o   Thanks for fixing it

Acked-by: Frederic Barrat <redacted>

  			ctx->tidr = current->thread.tidr;
  		}
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help