RE: [PATCH -next] ocxl: Fix missing unlock on error in afu_ioctl_enable_p9_wait()

-----Original Message-----
From: Wei Yongjun <redacted>
Sent: Tuesday, 5 June 2018 7:16 PM
To: Frederic Barrat <redacted>; Andrew Donnellan
[off-list ref]; Arnd Bergmann [off-list ref];
Greg Kroah-Hartman [off-list ref]; Alastair D'Silva
[off-list ref]
Cc: Wei Yongjun <redacted>; linuxppc-
dev@lists.ozlabs.org; linux-kernel@vger.kernel.org; kernel-
janitors@vger.kernel.org
Subject: [PATCH -next] ocxl: Fix missing unlock on error in
afu_ioctl_enable_p9_wait()

Add the missing unlock before return from function
afu_ioctl_enable_p9_wait() in the error handling case.

Fixes: e948e06fc63a ("ocxl: Expose the thread_id needed for wait on
POWER9")
Signed-off-by: Wei Yongjun <redacted>
---
 drivers/misc/ocxl/file.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/misc/ocxl/file.c b/drivers/misc/ocxl/file.c index

33ae46c..e6a6074 100644

--- a/drivers/misc/ocxl/file.c
+++ b/drivers/misc/ocxl/file.c

@@ -139,8 +139,10 @@ static long afu_ioctl_enable_p9_wait(struct

ocxl_context *ctx,
 		// Locks both status & tidr
 		mutex_lock(&ctx->status_mutex);
 		if (!ctx->tidr) {
-			if (set_thread_tidr(current))
+			if (set_thread_tidr(current)) {
+				mutex_unlock(&ctx->status_mutex);
 				return -ENOENT;
+			}

 			ctx->tidr = current->thread.tidr;
 		}