Thread (37 messages) 37 messages, 3 authors, 2018-05-03

Re: [PATCH 11/11] KVM: PPC: reconstruct LOAD_VSX/STORE_VSX instruction mmio emulation with analyse_intr() input

From: Simon Guo <hidden>
Date: 2018-05-03 09:46:46
Also in: kvm

On Thu, May 03, 2018 at 04:26:12PM +1000, Paul Mackerras wrote:
On Wed, Apr 25, 2018 at 07:54:44PM +0800, wei.guo.simon@gmail.com wrote:
quoted
From: Simon Guo <redacted>

This patch reconstructs LOAD_VSX/STORE_VSX instruction MMIO emulation with
analyse_intr() input. It utilizes VSX_FPCONV/VSX_SPLAT/SIGNEXT exported
by analyse_instr() and handle accordingly.

When emulating VSX store, the VSX reg will need to be flushed so that
the right reg val can be retrieved before writing to IO MEM.

Suggested-by: Paul Mackerras <redacted>
Signed-off-by: Simon Guo <redacted>
Looks good, except that you shouldn't need the special case for
stxsiwx.  With size=4 and element_size=8, kvmppc_handle_vsx_store
should just do the right thing, as far as I can see.
Yes. Let me test after update.

Thanks,
- Simon
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help