Thread (3 messages) flat view 3 messages, 2 authors, 2018-03-14

Re: [PATCH] powerpc/numa: Correct kernel message severity

From: Christophe LEROY <hidden>
Date: 2018-03-13 10:28:12


Le 13/03/2018 à 11:11, Vipin K Parashar a écrit :
quoted hunk ↗ jump to hunk
printk in unmap_cpu_from_node() uses KERN_ERR message severity
for a WARNING message. Correct message severity to KERN_WARNING.

Signed-off-by: Vipin K Parashar <redacted>
---
  arch/powerpc/mm/numa.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
index edd8d0b..79c94cc 100644
--- a/arch/powerpc/mm/numa.c
+++ b/arch/powerpc/mm/numa.c
@@ -163,7 +163,7 @@ static void unmap_cpu_from_node(unsigned long cpu)
  	if (cpumask_test_cpu(cpu, node_to_cpumask_map[node])) {
  		cpumask_clear_cpu(cpu, node_to_cpumask_map[node]);
  	} else {
-		printk(KERN_ERR "WARNING: cpu %lu not found in node %d\n",
+		printk(KERN_WARNING "WARNING: cpu %lu not found in node %d\n",
 >   		       cpu, node);

Why not take the opportunity to use pr_warn() instead, hence to put back 
the cpu and node vars on the same line.

Christophe
  	}
  }
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help