[PATCH] powerpc/numa: Correct kernel message severity

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE3067d

3 messages, 2 authors, 2018-03-14 · open the first message on its own page

[PATCH] powerpc/numa: Correct kernel message severity

From: Vipin K Parashar <hidden>
Date: 2018-03-13 10:23:00

printk in unmap_cpu_from_node() uses KERN_ERR message severity
for a WARNING message. Correct message severity to KERN_WARNING.

Signed-off-by: Vipin K Parashar <redacted>
---
 arch/powerpc/mm/numa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
index edd8d0b..79c94cc 100644
--- a/arch/powerpc/mm/numa.c
+++ b/arch/powerpc/mm/numa.c
@@ -163,7 +163,7 @@ static void unmap_cpu_from_node(unsigned long cpu)
 	if (cpumask_test_cpu(cpu, node_to_cpumask_map[node])) {
 		cpumask_clear_cpu(cpu, node_to_cpumask_map[node]);
 	} else {
-		printk(KERN_ERR "WARNING: cpu %lu not found in node %d\n",
+		printk(KERN_WARNING "WARNING: cpu %lu not found in node %d\n",
 		       cpu, node);
 	}
 }
-- 
2.7.4

Re: [PATCH] powerpc/numa: Correct kernel message severity

From: Christophe LEROY <hidden>
Date: 2018-03-13 10:28:12


Le 13/03/2018 à 11:11, Vipin K Parashar a écrit :
quoted hunk
printk in unmap_cpu_from_node() uses KERN_ERR message severity
for a WARNING message. Correct message severity to KERN_WARNING.

Signed-off-by: Vipin K Parashar <redacted>
---
  arch/powerpc/mm/numa.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
index edd8d0b..79c94cc 100644
--- a/arch/powerpc/mm/numa.c
+++ b/arch/powerpc/mm/numa.c
@@ -163,7 +163,7 @@ static void unmap_cpu_from_node(unsigned long cpu)
  	if (cpumask_test_cpu(cpu, node_to_cpumask_map[node])) {
  		cpumask_clear_cpu(cpu, node_to_cpumask_map[node]);
  	} else {
-		printk(KERN_ERR "WARNING: cpu %lu not found in node %d\n",
+		printk(KERN_WARNING "WARNING: cpu %lu not found in node %d\n",
 >   		       cpu, node);

Why not take the opportunity to use pr_warn() instead, hence to put back 
the cpu and node vars on the same line.

Christophe
  	}
  }

Re: [PATCH] powerpc/numa: Correct kernel message severity

From: Vipin K Parashar <hidden>
Date: 2018-03-14 07:54:05

On Tuesday 13 March 2018 03:58 PM, Christophe LEROY wrote:

Le 13/03/2018 à 11:11, Vipin K Parashar a écrit :
quoted
printk in unmap_cpu_from_node() uses KERN_ERR message severity
for a WARNING message. Correct message severity to KERN_WARNING.

Signed-off-by: Vipin K Parashar <redacted>
---
  arch/powerpc/mm/numa.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
index edd8d0b..79c94cc 100644
--- a/arch/powerpc/mm/numa.c
+++ b/arch/powerpc/mm/numa.c
@@ -163,7 +163,7 @@ static void unmap_cpu_from_node(unsigned long cpu)
      if (cpumask_test_cpu(cpu, node_to_cpumask_map[node])) {
          cpumask_clear_cpu(cpu, node_to_cpumask_map[node]);
      } else {
-        printk(KERN_ERR "WARNING: cpu %lu not found in node %d\n",
+        printk(KERN_WARNING "WARNING: cpu %lu not found in node %d\n",
                 cpu, node);
Why not take the opportunity to use pr_warn() instead, hence to put 
back the cpu and node vars on the same line.

Christophe
Yes, Thanks!!

Send v2.

quoted
      }
  }
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help