Re: [RFC][PATCH v2 7/7] checkpatch: add pF/pf deprecation warning

From
Joe Perches <joe@perches.com>
Date
2017-09-21 02:28:41
Also in
lkml
Reply to
Sergey Senozhatsky, 2017-09-21
On Thu, 2017-09-21 at 09:27 +0900, Sergey Senozhatsky wrote:
On (09/20/17 10:38), Joe Perches wrote:
quoted
On Thu, 2017-09-21 at 01:29 +0900, Sergey Senozhatsky wrote:
quoted
We deprecated '%pF/%pf' printk specifiers, since '%pS/%ps' is now smart
enough to handle function pointer dereference on platforms where such
dereference is required.

checkpatch warning example:

WARNING: Use '%pS/%ps' instead. This pointer extension was deprecated: '%pF'
If this series is accepted,  I think this message
is unclear and would prefer something like:
sure, can tweak the patch.

[..]
quoted
 			if ($bad_extension ne "") {
 				my $stat_real = raw_line($linenr, 0);
+				my $ext_type = "Invalid";
+				my $use = "";
 				for (my $count = $linenr + 1; $count <= $lc; $count++) {
 					$stat_real = $stat_real . "\n" . raw_line($count, 0);
 				}
+				if ($bad_extension =~ /p[Ff]/i) {
						I think /i is not necessary here
You are right, it's not.
Thread (29 messages) 29 messages, 7 authors, last reply 2017-10-19
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help