Re: [RFC][PATCH v2 7/7] checkpatch: add pF/pf deprecation warning
flat view
From: Sergey Senozhatsky <hidden>
Date: 2017-09-21 00:27:27
Also in:
lkml
On (09/20/17 10:38), Joe Perches wrote:
On Thu, 2017-09-21 at 01:29 +0900, Sergey Senozhatsky wrote:quoted
We deprecated '%pF/%pf' printk specifiers, since '%pS/%ps' is now smart enough to handle function pointer dereference on platforms where such dereference is required. checkpatch warning example: WARNING: Use '%pS/%ps' instead. This pointer extension was deprecated: '%pF'If this series is accepted, I think this message is unclear and would prefer something like:
sure, can tweak the patch. [..]
if ($bad_extension ne "") {
my $stat_real = raw_line($linenr, 0);
+ my $ext_type = "Invalid";
+ my $use = "";
for (my $count = $linenr + 1; $count <= $lc; $count++) {
$stat_real = $stat_real . "\n" . raw_line($count, 0);
}
+ if ($bad_extension =~ /p[Ff]/i) {I think /i is not necessary here
quoted hunk ↗ jump to hunk
+ $ext_type = "Deprecated"; + $use = " - use %pS instead"; + $use =~ s/pS/ps/ if ($bad_extension =~ /pf/);
ok, handy :) -ss