-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]
Sent: Wednesday, August 23, 2017 7:47 AM
To: Madalin-cristian Bucur <madalin.bucur@nxp.com>
Cc: netdev@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; linux-
kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/6] fsl/fman: enable FMan Keygen
=20
From: Madalin-cristian Bucur <madalin.bucur@nxp.com>
Date: Wed, 23 Aug 2017 04:36:56 +0000
=20

quoted

The struct fman is only visible in the fman file, the fman port
module uses struct fman as an opaque pointer, thus this export.

=20
Don't use that programming model.
=20
Export the datastructure properly to it's users.
=20
This abstraction scheme is so wasteful and costly.

Normally does not come with this cost, it's this case where one of the
sub-modules needs to call into another that gets things complicated.
I'll move struct fman to the header file.

Thanks,
Madalin