-----Original Message-----
From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org]
On Behalf Of David Miller
Sent: Wednesday, August 23, 2017 12:35 AM
Subject: Re: [PATCH v2 1/6] fsl/fman: enable FMan Keygen
=20
From: Madalin Bucur <madalin.bucur@nxp.com>
Date: Tue, 22 Aug 2017 20:31:01 +0300
=20

quoted

 /**
+ * fman_get_keygen
+ *
+ * @fman:	A Pointer to FMan device
+ *
+ * Get the handle to KeyGen module part of FM driver
+ *
+ * Return: Handle to KeyGen
+ */
+struct fman_keygen *fman_get_keygen(struct fman *fman)
+{
+	return fman->keygen;
+}
+EXPORT_SYMBOL(fman_get_keygen);

=20
Please don't do this.
=20
Just directly derefence the pointer in the source code to
get the keygen.
=20
Thank you.

Hi,

The struct fman is only visible in the fman file, the fman port module uses=
 struct
fman as an opaque pointer, thus this export.

Madalin