Re: block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()

From
SF Markus Elfring <hidden>
Date
2017-08-08 08:29:50
Also in
kernel-janitors, lkml
Reply to
Geoff Levand, 2017-08-07
quoted
https://patchwork.ozlabs.org/patch/798575/
I submitted your patch
Thanks for your constructive feedback.
https://patchwork.ozlabs.org/patch/798850/

and a fix to ps3vram_probe() with the other patches in my queue.
I find it nice that you picked this change opportunity up after
a bit of discussion (before an other developer would eventually
have tackled it also).

“Check return of ps3vram_cache_init”
https://patchwork.ozlabs.org/patch/798853/

1. Unfortunately, I find that this specific update suggestion does not fit
   to the Linux coding style convention.

   “…
   Do not unnecessarily use braces where a single statement will do.
   …”

2. How do you think about to use the check “if (error)” instead?

3. Will an additional commit description be useful?

Regards,
Markus
Thread (11 messages) 11 messages, 4 authors, last reply 2017-08-08
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help