Re: [PATCH] block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()
From: Geoff Levand <geoff@infradead.org>
Date: 2017-08-07 15:11:03
Also in:
kernel-janitors, lkml
On 08/07/2017 03:52 AM, SF Markus Elfring wrote:
From: Markus Elfring <redacted> Date: Mon, 7 Aug 2017 12:37:01 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software.
NACK When a user asks me for help I would certainly like to get 'Could not allocate cache tags' as apposed to nothing, since the return value of ps3vram_cache_init() is not checked. If you want to make an improvement please add a check for success of ps3vram_cache_init() in ps3vram_probe(). -Geoff