Thread (14 messages) 14 messages, 4 authors, 2017-08-08

RE: [PATCH 3/4] powerpc: pseries: only store the device node basename in full_name

From: David Laight <hidden>
Date: 2017-07-26 10:07:08
Also in: linux-devicetree, lkml

From: Rob Herring
Sent: 25 July 2017 22:44
With dependencies on full_name containing the entire device node path
removed, stop storing the full_name in nodes created by
dlpar_configure_connector() and pSeries_reconfig_add_node().
...
dn =3D kzalloc(sizeof(*dn), GFP_KERNEL);
	if (!dn)
		return NULL;
=20
	name =3D (char *)ccwa + be32_to_cpu(ccwa->name_offset);
-	dn->full_name =3D kasprintf(GFP_KERNEL, "%s/%s", path, name);
+	dn->full_name =3D kasprintf(GFP_KERNEL, "%s", name);
Isn't this just strdup()?
Perhaps you should rename full_name to name - since it is no longer 'full'?

Maybe you could do a single malloc() for both 'dn' and the name?

	David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help