RE: [PATCH 3/4] powerpc: pseries: only store the device node basename in full_name
From: David Laight <hidden>
Date: 2017-07-26 10:07:08
Also in:
linuxppc-dev, lkml
From: David Laight <hidden>
Date: 2017-07-26 10:07:08
Also in:
linuxppc-dev, lkml
From: Rob Herring
Sent: 25 July 2017 22:44 With dependencies on full_name containing the entire device node path removed, stop storing the full_name in nodes created by dlpar_configure_connector() and pSeries_reconfig_add_node().
...
dn = kzalloc(sizeof(*dn), GFP_KERNEL); if (!dn) return NULL; name = (char *)ccwa + be32_to_cpu(ccwa->name_offset); - dn->full_name = kasprintf(GFP_KERNEL, "%s/%s", path, name); + dn->full_name = kasprintf(GFP_KERNEL, "%s", name);
Isn't this just strdup()? Perhaps you should rename full_name to name - since it is no longer 'full'? Maybe you could do a single malloc() for both 'dn' and the name? David -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html