Thread (7 messages) flat view 7 messages, 3 authors, 2017-07-07

Re: [git pull] vfs.git part 1

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2017-07-07 15:59:46
Also in: linux-fsdevel, lkml

On Fri, Jul 7, 2017 at 5:46 AM, Michael Ellerman [off-list ref] wrote:
Al Viro [off-list ref] writes:
quoted
  Switch flock copyin/copyout primitives to copy_{from,to}_user() (2017-06-26 23:52:44 -0400)
This commit seems to have broken networking on a bunch of my PPC
machines (64-bit kernel, 32-bit userspace).
Bah. I think that commit is entirely broken, due to having the
arguments to the "copy_flock_fields()" in the wrong order.

The copy_flock_fields() macro has the arguments in order <from, to>,
but all the users seem to do it the other way around.

I think it would have been more obvious if the put_compat_flock*()
source argument had been "const".
Patch coming.
I'm not seeing a patch, so I did my own. But it's _entirely_ untested.
Does the attached fix things for you?

                     Linus

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help