Thread (7 messages) flat view 7 messages, 3 authors, 2017-07-07

Re: [git pull] vfs.git part 1

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2017-07-07 22:50:40
Also in: linux-fsdevel, lkml

Linus Torvalds [off-list ref] writes:
On Fri, Jul 7, 2017 at 8:59 AM, Linus Torvalds
[off-list ref] wrote:
quoted
The copy_flock_fields() macro has the arguments in order <from, to>,
but all the users seem to do it the other way around.
Looking more at it, I think I'd also like copy_flock_fields() to take
pointer arguments, to match all the code around it (both
copy_to/from_user and the memset calls.

The actual order of arguments I suspect Michael's patch did better -
make the copy_flock_fields() just match the order of memcpy() and
copy_to/from_user(), both of which have <dest,src> order.

So I think my preferred patch would be something like this, even if it
is bigger than either.

Comments? Michael, does this work for your case?
Yeah that works, as committed in your tree. Sorry for the slow reply,
our time zones don't line up all that well :)

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help