Re: [PATCH v2 1/9] powerpc/lib/code-patching: Enhance code patching

Hi Balbir

Le 04/06/2017 à 01:45, kbuild test robot a écrit :

Hi Balbir,

[auto build test ERROR on powerpc/next]
[also build test ERROR on v4.12-rc3 next-20170602]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Balbir-Singh/Enable-STRICT_KERNEL_RWX/20170603-161759
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-kilauea_defconfig (attached as .config)
compiler: powerpc-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
         wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
         chmod +x ~/bin/make.cross
         # save the attached .config to linux build tree
         make.cross ARCH=powerpc

All errors (new ones prefixed by >>):

    arch/powerpc/lib/code-patching.c: In function 'kernel_map_addr':

quoted

quoted

arch/powerpc/lib/code-patching.c:93:8: error: implicit declaration of function 'map_kernel_page' [-Werror=implicit-function-declaration]

      err = map_kernel_page(
            ^~~~~~~~~~~~~~~
    cc1: all warnings being treated as errors

You should probably include my patch (the one renaming map_page() to 
map_kernel_page() ) in as first patch in your serie in order to get a 
clean serie and avoid such reports from the robot.

Christophe

vim +/map_kernel_page +93 arch/powerpc/lib/code-patching.c

     87	
     88		if (is_vmalloc_addr(addr))
     89			pfn = vmalloc_to_pfn(addr);
     90		else
     91			pfn = __pa_symbol(addr) >> PAGE_SHIFT;
     92	
   > 93		err = map_kernel_page(
     94				(unsigned long)__this_cpu_read(text_poke_area)->addr,
     95				(pfn << PAGE_SHIFT), _PAGE_KERNEL_RW | _PAGE_PRESENT);
     96		pr_devel("Mapped addr %p with pfn %lx\n",

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation