Re: RFC: better timer interface

From
Arnd Bergmann <arnd@arndb.de>
Date
2017-05-22 11:26:37
Also in
linux-s390, lkml
Reply to
Thomas Gleixner, 2017-05-21
On Sun, May 21, 2017 at 8:14 PM, Thomas Gleixner [off-list ref] wrote:
On Sun, 21 May 2017, Thomas Gleixner wrote:
quoted
On Tue, 16 May 2017, Arnd Bergmann wrote:
quoted
On Tue, May 16, 2017 at 5:51 PM, Christoph Hellwig [off-list ref] wrote:
quoted
Yes, that sounds useful to me as well.  As you said it's an independent
but somewhat related change.  I can add it to my series, but I'll
need a suggestions for a good and short name.  That already was the
hardest part for the setup side :)
If we keep the unusual *_timer() naming (rather than timer_*() as hrtimer
has), we could use one of

a) start_timer(struct timer_list *timer, unsigned long ms);
b) restart_timer(struct timer_list *timer, unsigned long ms);
c) mod_timer_ms(struct timer_list *timer, unsigned long ms);
    mod_timer_sec(struct timer_list *timer, unsigned long sec);
Please make new functions prefixed with timer_ and get rid of that old
interface completely. It's horrible.

timer_init()
timer_start(timer, ms, abs)
I'm not even sure, whether we need absolute timer wheel timers at
all, because most use cases are relative to now.

But it's easy enough to provide them. All we need for that is something
like

        unsigned long time_msec;

which gets incremented every tick by the appropriate amount of
milliseconds.

Having that would also allow to replace all the

       end = jiffies + msec_to_jiffies(xxx);

       while (time_before(jiffies, end))
             ....

constructs with a milliseconds based machinery. So we can remove all
*_to_jiffies() interfaces over time.
A lot of those users could probably just ktime_get()/ktime_before() here,
as they would by definition not be performance critical.

I don't see a way to just tk->tkr_mono.base but with a ktime_get_coarse()
we could just return the ktime_t of the last tick and not even need a seqlock
on 64-bit architectures, or have to introduce a new API.

        Arnd
Thread (39 messages) 39 messages, 7 authors, last reply 2017-05-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help