Thread (12 messages) 12 messages, 2 authors, 2017-04-11

Re: [PATCH v3 2/5] perf/x86/intel: Record branch type

From: Peter Zijlstra <peterz@infradead.org>
Date: 2017-04-11 08:35:34
Also in: lkml

On Tue, Apr 11, 2017 at 04:11:21PM +0800, Jin, Yao wrote:

On 4/11/2017 3:52 PM, Peter Zijlstra wrote:
quoted
This is still a completely inadequate changelog. I really will not
accept patches like this.
Hi,

The changelog is added in the cover-letter ("[PATCH v3 0/5] perf report: Show branch type").

Does the changelog need to be added in each patch's description?

That's fine, I can add and resend this patch.
The cover letter is not retained; it is throw away information.

Each patch should have a coherent changelog that explain why the patch
was done and explain non trivial things in the implementation.

Simply copy/pasting the same story in multiple patches is not right
either, for the simple fact that the patches were not the same. You did
a different thing, so you need a different story.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help