Re: [PATCH] powerpc: fix sparse warning, include kernel header
From: Daniel Axtens <hidden>
Date: 2017-03-10 00:40:29
Hi Tobin, I have built the kernel with the ppc6xx_defconfig with and without your patch. Using my smart-sparse-diff tool[1], I have confirmed the warning disappears: -/scratch/dja/linux/arch/powerpc/kernel/swsusp.c:17:6: warning: symbol 'save_processor_state' was not declared. Should it be static? -/scratch/dja/linux/arch/powerpc/kernel/swsusp.c:31:6: warning: symbol 'restore_processor_state' was not declared. Should it be static? As such, this patch is: Reviewed-by: Daniel Axtens <redacted> Thanks for fixing this! Regards, Daniel [1] https://github.com/daxtens/smart-sparse-diff "Tobin C. Harding" [off-list ref] writes:
quoted hunk ↗ jump to hunk
Spares emits two symbol not declared warnings. The two functions in question are declared already in a kernel header. Add include directive to include kernel header. Signed-off-by: Tobin C. Harding <redacted> --- github issue: #37 Fix sparse errors arch/powerpc/kernel/swsusp.c | 1 + 1 file changed, 1 insertion(+)diff --git a/arch/powerpc/kernel/swsusp.c b/arch/powerpc/kernel/swsusp.c index 6ae9bd5..0050b2d 100644 --- a/arch/powerpc/kernel/swsusp.c +++ b/arch/powerpc/kernel/swsusp.c@@ -10,6 +10,7 @@ */ #include <linux/sched.h> +#include <linux/suspend.h> #include <asm/current.h> #include <asm/mmu_context.h> #include <asm/switch_to.h>-- 2.7.4