From: Tobin C. Harding <hidden> Date: 2017-03-06 08:26:56
Spares emits two symbol not declared warnings. The two functions in
question are declared already in a kernel header.
Add include directive to include kernel header.
Signed-off-by: Tobin C. Harding <redacted>
---
github issue: #37 Fix sparse errors
arch/powerpc/kernel/swsusp.c | 1 +
1 file changed, 1 insertion(+)
From: Daniel Axtens <hidden> Date: 2017-03-10 00:40:29
Hi Tobin,
I have built the kernel with the ppc6xx_defconfig with and without your
patch.
Using my smart-sparse-diff tool[1], I have confirmed the warning
disappears:
-/scratch/dja/linux/arch/powerpc/kernel/swsusp.c:17:6: warning: symbol 'save_processor_state' was not declared. Should it be static?
-/scratch/dja/linux/arch/powerpc/kernel/swsusp.c:31:6: warning: symbol 'restore_processor_state' was not declared. Should it be static?
As such, this patch is:
Reviewed-by: Daniel Axtens <redacted>
Thanks for fixing this!
Regards,
Daniel
[1] https://github.com/daxtens/smart-sparse-diff
"Tobin C. Harding" [off-list ref] writes:
quoted hunk
Spares emits two symbol not declared warnings. The two functions in
question are declared already in a kernel header.
Add include directive to include kernel header.
Signed-off-by: Tobin C. Harding <redacted>
---
github issue: #37 Fix sparse errors
arch/powerpc/kernel/swsusp.c | 1 +
1 file changed, 1 insertion(+)
From: Tobin C. Harding <hidden> Date: 2017-03-11 22:19:52
On Fri, Mar 10, 2017 at 11:40:23AM +1100, Daniel Axtens wrote:
Hi Tobin,
I have built the kernel with the ppc6xx_defconfig with and without your
patch.
Using my smart-sparse-diff tool[1], I have confirmed the warning
disappears:
-/scratch/dja/linux/arch/powerpc/kernel/swsusp.c:17:6: warning: symbol 'save_processor_state' was not declared. Should it be static?
-/scratch/dja/linux/arch/powerpc/kernel/swsusp.c:31:6: warning: symbol 'restore_processor_state' was not declared. Should it be static?
As such, this patch is:
Reviewed-by: Daniel Axtens <redacted>
Spares emits two symbol not declared warnings. The two functions in
question are declared already in a kernel header.
Add include directive to include kernel header.
Signed-off-by: Tobin C. Harding <redacted>
---
github issue: #37 Fix sparse errors
arch/powerpc/kernel/swsusp.c | 1 +
1 file changed, 1 insertion(+)
From: Michael Ellerman <hidden> Date: 2017-03-21 11:36:14
On Mon, 2017-03-06 at 08:25:31 UTC, "Tobin C. Harding" wrote:
Spares emits two symbol not declared warnings. The two functions in
question are declared already in a kernel header.
Add include directive to include kernel header.
Signed-off-by: Tobin C. Harding <redacted>