Re: [RESEND-RFC v2 2/3] powerpc/eeh: Introduce function eeh_pe_reset_freeze_counter()
From: Vaibhav Jain <hidden>
Date: 2017-03-03 04:21:26
Hi Russell, Vaibhav Jain [off-list ref] writes:
This patch introduces function eeh_pe_reset_freeze_counter() which can be used to reset the PE's freeze count variable outside eeh code. This is useful for devices that can acquire a different personality after a PERST event (e.g FPGA Adapters). Presently an existing freeze count for an adapter with personality N will be taken into account when the adapter acquired personality N+1. By calling eeh_pe_reset_freeze_counter() drivers can reset the freeze counter for an adapter once it has acquired a new personality and ideally wont be plagued by the failures similar to the one before. Signed-off-by: Vaibhav Jain <redacted> ---
Had a short chat discussion with Gavin Shan on this patchset and he preffers restoring the freeze_count on the eeh_pe once FRESET is done. He expects a the flow to be similar to one below 1. module caches the value of freeze_count and resets it 2. Issue warm reset 3. During eeh error-detected callback module restores the freeze_count from the cached value. Russell, what do you think? -- Vaibhav Jain [off-list ref] Linux Technology Center, IBM India Pvt. Ltd.