Thread (4 messages) flat view 4 messages, 3 authors, 2016-11-11

Re: [PATCH] of/irq: improve error message on irq discovery process failure

From: Benjamin Herrenschmidt <hidden>
Date: 2016-11-11 19:12:27
Also in: linux-devicetree, linux-pci

On Fri, 2016-11-11 at 16:32 +0000, Mark Rutland wrote:
On Fri, Nov 11, 2016 at 08:30:43AM +1100, Benjamin Herrenschmidt
wrote:
quoted
On Wed, 2016-11-09 at 19:04 +0000, Mark Rutland wrote:
quoted

If we don't have an interrupt-map on a PCI controller, why don't
we
instead log a message regarding that being missing, and give up
early?
Why ? It's legit to not support LSIs.
Sure; I had envisioned a message like:

	pr_info("%s: no interrupt-map, INTx interrupts not possible\n",
		pci_controller_name);

... Which tells the user exaclty what we know, and doesn't imply
either
an error or the actual absence of HW support.
Works for me.

Cheers,
Ben.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help