Thread (4 messages) 4 messages, 2 authors, 2016-10-26

Re: [bug report] [POWERPC] 4xx: Add 405GPr and 405EP support in boot wrapper

From: Dan Carpenter <hidden>
Date: 2016-10-26 19:08:03

On Wed, Oct 26, 2016 at 01:57:23PM -0500, Benjamin Herrenschmidt wrote:
On Wed, 2016-10-26 at 16:03 +0300, Dan Carpenter wrote:
quoted
   565          cbdv = ((pllmr & 0x00060000) >> 17) + 1; /* CPU:PLB */
   566          opdv = ((pllmr & 0x00018000) >> 15) + 1; /* PLB:OPB */
   567          ppdv = ((pllmr & 0x00001800) >> 13) + 1; /* PLB:PCI */
                                 ^^^^^^^^^^^^^^^^^
This is zero.  It looks like 0x00000600 was probably intended?
I just checked the spec and for the 405gp and it's 0x6000 (bits 17 and
18 in IBM ordering)
I'm on the road and there is no way I'm going to remember to do this
when I get back...  Could you send the patch?

regards,
dan carpenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help