Re: [2/9] powerpc/powernv: Use CPU-endian hub diag-data type in pnv_eeh_get_and_dump_hub_diag()
From: Michael Ellerman <hidden>
Date: 2016-10-05 02:36:26
On Tue, 2016-02-08 at 04:10:30 UTC, Gavin Shan wrote:
The hub diag-data type is filled with big-endian data by OPAL call
opal_pci_get_hub_diag_data(). We need convert it to CPU-endian value
before using it. The issue is reported by sparse as pointed by Michael
Ellerman:
gwshan@gwshan:~/sandbox/l$ make C=2 CF=-D__CHECK_ENDIAN__ \
arch/powerpc/platforms/powernv/eeh-powernv.o
:
arch/powerpc/platforms/powernv/eeh-powernv.c:1309:21: \
warning: restricted __be16 degrades to integer
arch/powerpc/platforms/powernv/eeh-powernv.c:1309:21: \
warning: restricted __be16 degrades to integer
arch/powerpc/platforms/powernv/eeh-powernv.c:1309:21: \
warning: restricted __be16 degrades to integer
arch/powerpc/platforms/powernv/eeh-powernv.c:1309:21: \
warning: restricted __be16 degrades to integer
arch/powerpc/platforms/powernv/eeh-powernv.c:1309:21: \
warning: restricted __be16 degrades to integer
This converts hub diag-data type to CPU-endian before using it in
pnv_eeh_get_and_dump_hub_diag().
Fixes: 2a485ad7c88d ("powerpc/powernv: Drop PHB operation next_error()")
Cc: stable@vger.kernel.org # v4.1+
Suggested-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Gavin Shan <redacted>
Reviewed-by: Russell Currey <redacted>Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/a7032132d7560a8434e1f54b71efd7 cheers