Re: [PATCH 1/9] powerpc/powernv: Pass CPU-endian PE number to opal_pci_eeh_freeze_clear()
From: Russell Currey <hidden>
Date: 2016-08-02 04:33:01
On Tue, 2016-08-02 at 14:10 +1000, Gavin Shan wrote:
The PE number (@frozen_pe_no), filled by opal_pci_next_error() is in
big-endian format. It should be converted to CPU-dian before it is
passed to opal_pci_eeh_freeze_clear() when clearing the frozen state
if the PE is invalid one. As Michael Ellerman pointed out, the issue
is also detected by sparse:
gwshan@gwshan:~/sandbox/l$ make C=2 CF=-D__CHECK_ENDIAN__ \
arch/powerpc/platforms/powernv/eeh-powernv.o
:
arch/powerpc/platforms/powernv/eeh-powernv.c:1541:41: \
warning: incorrect type in argument 2 (different base types)
arch/powerpc/platforms/powernv/eeh-powernv.c:1541:41: \
expected unsigned long long [unsigned] [usertype] pe_number
arch/powerpc/platforms/powernv/eeh-powernv.c:1541:41: \
got restricted __be64 [addressable] [usertype] frozen_pe_no
This passes CPU-endian PE number to opal_pci_eeh_freeze_clear() and
it should be part of commit <0f36db77643b> ("powerpc/eeh: Fix wrong
printed PE number"), which was merged to 4.3 kernel.
Fixes: 71b540adffd9 ("powerpc/powernv: Don't escalate non-existing frozen PE")
Cc: stable@vger.kernel.org # v4.3+
Suggested-by: Paul Mackerras <redacted>
Signed-off-by: Gavin Shan <redacted>
---Reviewed-by: Russell Currey <redacted>