Thread (20 messages) 20 messages, 6 authors, 2016-09-14

Re: [v2,4/5] powerpc/fadump: Make ELF eflags depend on endian

From: Michael Ellerman <hidden>
Date: 2016-09-13 12:16:32

On Tue, 2016-06-09 at 05:32:42 UTC, Daniel Axtens wrote:
Firmware Assisted Dump is a facility to dump kernel core with assistance
from firmware.  As part of this process the kernel ELF version is
stored.

Currently, fadump.h defines this to 0 if it is not already defined. This
clashes with a define in elf.h which sets it based on the current task -
not based on the kernel.

When the kernel is compiled on LE, the kernel will always be version
2. Otherwise it will be version 0. So the correct behaviour is to set
the ELF eflags based on the endianness of the kernel. Do that.

Remove the definition in fadump.h, which becomes unused.

Cc: Mahesh Salgaonkar <redacted>
Cc: Hari Bathini <redacted>
Signed-off-by: Daniel Axtens <redacted>
Reviewed-by: Mahesh Salgaonkar <redacted>
Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/d8bced27be25537bde3714cbdb

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help