Re: [PATCH v2 1/5] powerpc/cell: drop unused iic_get_irq_host()

On Tuesday, September 6, 2016 3:32:39 PM CEST Daniel Axtens wrote:

Sparse checking revealed that it is no longer used.
There is an EXPORT_SYMBOL_GPL, but there's no header that
provides a prototype, so nothing should be using it anyway.

Remove it.

Signed-off-by: Daniel Axtens <redacted>

Acked-by: Arnd Bergmann <arnd@arndb.de>

Good catch!

I'm currently experimenting with a patch that adds -Wmissing-declaration to
the normal kernel CFLAGS for everyone, and fixing up the warnings I get with
that on ARM.

Are you looking at all the powerpc specific code? If we can catch all the
existing warnings for some of the major architectures, we can hopefully
enable this in the mainline kernel at some point so we don't need sparse
for it any more.

	Arnd