Re: [PATCH v3 10/21] powerpc/mm: Define radix_enabled() in one place & use static inline

From
Michael Ellerman <mpe@ellerman.id.au>
Date
2016-07-30 10:08:16
Reply to
Balbir Singh, 2016-07-29
Balbir Singh [off-list ref] writes:
On Fri, 2016-07-29 at 21:42 +1000, Michael Ellerman wrote:
quoted
Nicholas Piggin [off-list ref] writes:
quoted
Won't MMU_FTRS_POSSIBLE just do the right thing when
!CONFIG_PPC_RADIX_MMU?
Yes it should.

I'll have to work out why Aneesh thought he needed to do it explicitly
and whether that is needed or not.
IIRC, If CONFIG_PPC_RADIX_MMU=3Dn MMU_FTR_RAIDX will not be present in the
MMU_FTRS_POSSIBLE mask=C2=A0
That's right.

The obvious thing to do would be to define MMU_FTR_RADIX to 0 when
RADIX=3Dn, but that doesn't work because it breaks the ASM FTR macros
(because they check (mmu_features & mask) =3D=3D mask).

So instead we just remove it from the possible mask.

cheers
Thread (40 messages) 40 messages, 5 authors, last reply 2016-08-08
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help