Re: [PATCH v3 12/21] powerpc/mm: Convert early cpu/mmu feature check to use the new helpers

From
Nicholas Piggin <npiggin@gmail.com>
Date
2016-07-28 07:49:40
Reply to
Michael Ellerman, 2016-07-27
On Thu, 28 Jul 2016 00:18:08 +1000
Michael Ellerman [off-list ref] wrote:
From: "Aneesh Kumar K.V" <redacted>

This switches early feature checks to use the non static key variant
of the function. In later patches we will be switching
cpu_has_feature() and mmu_has_feature() to use static keys and we can
use them only after static key/jump label is initialized. Any check
for feature before jump label init should be done using this new
helper.
Can't convince you to call it *_has_feature_early()?

Any point to a WARN_ON_ONCE() in these guys that trips if they are
used after the jump labels are set up?

Thanks,
Nick
Thread (40 messages) 40 messages, 5 authors, last reply 2016-08-08
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help