RE: [PATCH 1/2] qe/ic: move qe_ic_init from platforms to irqchip

On 07/05/2016 11:19 AM, Jason Cooper [off-list ref] wrote:

-----Original Message-----
From: Jason Cooper [mailto:jason@lakedaemon.net]
Sent: Tuesday, July 05, 2016 10:22 PM
To: Qiang Zhao <qiang.zhao@nxp.com>
Cc: oss@buserror.net; tglx@linutronix.de; marc.zyngier@arm.com; linuxppc-
dev@lists.ozlabs.org; linux-kernel@vger.kernel.org; Xiaobo Xie
[off-list ref]
Subject: Re: [PATCH 1/2] qe/ic: move qe_ic_init from platforms to irqchip
=20
On Tue, Jul 05, 2016 at 07:27:21AM +0000, Qiang Zhao wrote:

quoted

On 07/05/2016 11:19 AM, Jason Cooper [off-list ref] wrote:

quoted

-----Original Message-----
From: Jason Cooper [mailto:jason@lakedaemon.net]
Sent: Tuesday, July 05, 2016 11:19 AM
To: Qiang Zhao <qiang.zhao@nxp.com>
Cc: oss@buserror.net; tglx@linutronix.de; marc.zyngier@arm.com;
linuxppc- dev@lists.ozlabs.org; linux-kernel@vger.kernel.org; Xiaobo
Xie [off-list ref]
Subject: Re: [PATCH 1/2] qe/ic: move qe_ic_init from platforms to

quoted

diff --git a/arch/powerpc/platforms/83xx/misc.c

b/arch/powerpc/platforms/83xx/misc.c
index 7e923ca..9431fc7 100644

--- a/arch/powerpc/platforms/83xx/misc.c
+++ b/arch/powerpc/platforms/83xx/misc.c

@@ -93,24 +93,9 @@ void __init mpc83xx_ipic_init_IRQ(void)  }

 #ifdef CONFIG_QUICC_ENGINE
-void __init mpc83xx_qe_init_IRQ(void) -{
-	struct device_node *np;
-
-	np =3D of_find_compatible_node(NULL, NULL, "fsl,qe-ic");
-	if (!np) {
-		np =3D of_find_node_by_type(NULL, "qeic");
-		if (!np)
-			return;
-	}

This block isn't preserved in the irqchip driver.  Why not?

I grep qeic in arch/powerpc/boot/dts/*, doesn't find which board use qe=

ic as

type.
=20
Unfortunately, checking powerpc/boot/dts/* isn't sufficient for confirmin=

g we

aren't going to break backwards compatibility with boards *in the field*.
=20
Please take a look at:
=20
  d4fb5ebd83c70 powerpc/83xx: consolidate init_IRQ functions
  8159df72d43e2 83xx: add support for the kmeter1 board.
=20
Perhaps one or two of the authors is still around and can say why that ch=

eck is

there and if it's ok to remove it.
=20
Or, we could just play it safe and keep the check.
=20

Ok, I will add this check in next version.

Thanks
-Zhao Qiang