Re: [PATCH 2/2] qe/ic: refactor qe_ic to simplify

Morning!

On Tue, Jul 05, 2016 at 07:38:49AM +0000, Qiang Zhao wrote:

On 07/05/2016 11:51 AM, Jason Cooper [off-list ref] wrote:

quoted

On Tue, Jul 05, 2016 at 09:46:59AM +0800, Zhao Qiang wrote:

...

quoted

quoted

Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
 drivers/irqchip/qe_ic.c    | 83 +++++++++++++++++++++++++------------------

---

quoted

 include/soc/fsl/qe/qe_ic.h |  7 ----
 2 files changed, 45 insertions(+), 45 deletions(-)

diff --git a/drivers/irqchip/qe_ic.c b/drivers/irqchip/qe_ic.c index

f7f9a81..46652c0 100644

--- a/drivers/irqchip/qe_ic.c
+++ b/drivers/irqchip/qe_ic.c

...

quoted

quoted

-	printk(KERN_DEBUG "Registering qe_ic with sysfs...\n");
+	ret = qe_ic_init(0);

Sorry, build machine is down atm.  How was qe_ic_init() called previously?  Is
that removed?

Sorry, I don't understand, could you please explain?

-ENOSLEEP when I wrote that.  :)  *My* build machine, with my copies of
the kernel tree was down, so I had no easy way to dig into the source.

And ....

quoted

quoted

-static int __init qeic_of_init(void)
-{
-	struct device_node *np;
-
-	np = of_find_compatible_node(NULL, NULL, "fsl,qe-ic");
-	if (np) {
-		qe_ic_init(np, 0, qe_ic_cascade_low_mpic,
-			   qe_ic_cascade_high_mpic);
-		of_node_put(np);
-	}
 	return 0;
 }

-subsys_initcall(qeic_of_init);

this block is what I missed last night. :-/  Sorry for the noise.

thx,

Jason.