Re: [PATCH] cxl: Abstract the differences between the PSL and XSL
From: John W Walthour <hidden>
Date: 2016-05-27 13:08:00
<div class=3D"socmaildefaultfont" dir=3D"ltr" style=3D"font-family:Arial;fo=
nt-size:10.5pt" ><div dir=3D"ltr" > </div>
<div dir=3D"ltr" >Those come from
<div>XSL=5Fdatabook=5F09=5FJune=5F2014.pdf</div>
<div> </div>
<div>The registers in this doc listed at 0x400-600 are offset by 0x400, so =
0x568 =3D 0x168.</div>
<div> </div>
<div><font face=3D"Arial" size=3D"2" >John Walthour</font><br><i><font face=
=3D"Courier New" color=3D"#808080" size=3D"2" >Development Engineer<br>IBM =
Corporation | Systems & Technology Group</font></i><br><i><font face=3D=
"Courier New" color=3D"#808080" size=3D"2" >Phone: (512) 973-1095 | T/L: 36=
3-1095<br>Email: </font></i><a href=3D"mailto:jwalthour@us.ibm.com" ><i><u>=
<font face=3D"Courier New" color=3D"#0000FF" size=3D"2" >jwalthour@us.ibm.c=
om</font></u></i></a><br><br><i><font face=3D"Courier New" color=3D"#808080=
" size=3D"2" >return 0</font></i>
<div> </div>
<div> </div>
<blockquote data-history-content-modified=3D"1" style=3D"border-left:solid =
#aaaaaa 2px; margin-left:5px; padding-left:5px; direction:ltr; margin-right=
:0px" >----- Original message -----<br>From: Frederic Barrat <fbarrat@li=
nux.vnet.ibm.com><br>Sent by: "Linuxppc-dev" <linuxppc-dev-bounces+jw=
althour=3Dus.ibm.com@lists.ozlabs.org><br>To: Ian Munsie <imunsie@au1=
.ibm.com>, Michael Ellerman <mpe@ellerman.id.au>, mikey <mikey@=
neuling.org>, linuxppc-dev@lists.ozlabs.org, Frederic Barrat <frederi=
c.barrat@fr.ibm.com>, Huy Nguyen <huyn@mellanox.com><br>Cc:<br>Sub=
ject: Re: [PATCH] cxl: Abstract the differences between the PSL and XSL<br>=
Date: Fri, May 27, 2016 7:49 AM<br>
<div><font face=3D"Default Monospace,Courier New,Courier,monospace" size=3D=
"2" >Hi Ian,<br><br>It looks good, just one question:<br><br>> +/* XSL r=
egisters (Mellanox CX4) */<br>> +static const cxl=5Fp1=5Freg=5Ft CXL=5FX=
SL=5FTimebase =3D {0x0100};<br>> +static const cxl=5Fp1=5Freg=5Ft =
CXL=5FXSL=5FTB=5FCTLSTAT =3D {0x0108};<br>> +static const cxl=5Fp1=5Freg=
=5Ft CXL=5FXSL=5FFEC =3D {0x0158};<br>> +static con=
st cxl=5Fp1=5Freg=5Ft CXL=5FXSL=5FDSNCTL =3D {0x0168};<br><br>=
Out of curiosity, in which document did you get those offsets from? I<br>re=
member there used to be some confusion about it. All I could find was<br>th=
e internal offsets the firmware remaps those to (in xsl databook).<br><br>F=
eel free to grab the "From:", since the patch has evolved since I<br>worked=
on it. I don't care.<br><br> Fred<br><br>=5F=5F=5F=5F=5F=5F=5F=
=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=
=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F<br>Linuxppc-dev mailing list<=
br>Linuxppc-dev@lists.ozlabs.org<br><a href=3D"https://lists.ozlabs.org/lis=
tinfo/linuxppc-dev" target=3D"=5Fblank" >https://lists.ozlabs.org/listinfo/=
linuxppc-dev</a></font></div></blockquote></div></div></div><BR>