Thread (26 messages) 26 messages, 3 authors, 2016-05-20

Re: [PATCH v2 2/9] powerpc/kvm: make hypervisor state restore a function

From: Paul Mackerras <hidden>
Date: 2016-05-20 03:19:57
Also in: lkml

On Tue, May 03, 2016 at 01:54:31PM +0530, Shreyas B. Prabhu wrote:
In the current code, when the thread wakes up in reset vector, some
of the state restore code and check for whether a thread needs to
branch to kvm is duplicated. Reorder the code such that this
duplication is avoided.
This is a nice cleanup.  The one minor comment I have is that since
power7_restore_hyp_resource has some unusual entry requirements (such
as requiring cr3 to be set a certain way), those requirements should
be documented in the comment just about the function entry point.  I
didn't see any unusual exit conditions, but if there are any they
should be documented too.

Reviewed-by: Paul Mackerras <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help