RE: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0

From
Yang-Leo Li <hidden>
Date
2016-04-06 19:27:22
Reply to
Brian Norris, 2016-04-06
-----Original Message-----
From: Brian Norris [mailto:computersforpeace@gmail.com]
Sent: Wednesday, April 06, 2016 12:53 PM
To: Li Yang <redacted>
Cc: Scott Wood <oss@buserror.net>; Raghav Dogra <redacted>;
linux-mtd@lists.infradead.org; linuxppc-dev <linuxppc-dev@lists.ozlabs.or=
g>;
Prabhakar Kushwaha [off-list ref]; Raghav Dogra
[off-list ref]; Jaiprakash Singh [off-list ref]; Boris
Brezillon [off-list ref]
Subject: Re: [PATCH][v3] mtd/ifc: Add support for IFC controller version =
2.0
=20
Hi,
=20
On Wed, Mar 30, 2016 at 03:43:40PM -0500, Li Yang wrote:
quoted
Hi Brian,

Could you help to review and pull in this patch and the Kconfig update
after this patch(https://patchwork.ozlabs.org/patch/557389/)?  It
=20
It's probably best for Boris to apply this now.
Thanks Brian.  I see Boris is taking over the maintenance of NAND recently,=
 we will follow up with him.

Hi Boris,

Can you consider to pull in this patch and then Kconfig patch (https://patc=
hwork.ozlabs.org/patch/557389/)?

Regards,
Leo
=20
quoted
stated a dependency in the notes, but actually it should be applied
cleanly without that patch.  These patches are critical to make NAND
mtd feature work for our new chips.

Regards,
Leo

On Thu, Feb 18, 2016 at 6:07 PM, Scott Wood [off-list ref] wrote:
quoted
On Thu, 2016-02-18 at 15:18 -0600, Leo Li wrote:
quoted
On Wed, Feb 17, 2016 at 5:24 AM, Raghav Dogra [off-list ref]
wrote:
quoted
quoted
quoted
quoted
The new IFC controller version 2.0 has a different memory map page=
.
quoted
quoted
quoted
quoted
Upto IFC 1.4 PAGE size is 4 KB and from IFC2.0 PAGE size is 64KB.
This patch segregates the IFC global and runtime registers to
appropriate PAGE sizes.

Signed-off-by: Jaiprakash Singh <redacted>
Signed-off-by: Raghav Dogra <redacted>
Acked-by: Li Yang <redacted>
Signed-off-by: Raghav Dogra <redacted>
---
Changes for v3: not dependent on
"drivers/memory: Add deep sleep support for IFC" patch

Changes for v2: rebased to resolve conflicts Applicable to
git://git.infradead.org/l2-mtd.git

This patch is dependent on "drivers/memory: Add deep sleep
support for IFC"
https://patchwork.ozlabs.org/patch/582762/
which is also applicable to git://git.infradead.org/l2-mtd.git
=20
For the patch:
=20
Acked-by: Brian Norris <computersforpeace@gmail.com>
=20
quoted
quoted
quoted
This patch seems to be in good shape, but the dependency is still
having quite some feedback to be addressed.  Depending on it will
greatly delay the time that this critical patch for LS2 to be merged=
.
quoted
quoted
quoted
Could you remove the dependency like Scott already suggested?
According to the changelog the dependency has been removed (it would
have been clearer to remove this comment as well...).

-Scott


--
- Leo
Thread (17 messages) 17 messages, 7 authors, last reply 2016-06-29
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help