Re: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0

From
Brian Norris <computersforpeace@gmail.com>
Date
2016-04-06 17:53:05
Reply to
Li Yang, 2016-03-30
Hi,

On Wed, Mar 30, 2016 at 03:43:40PM -0500, Li Yang wrote:
Hi Brian,

Could you help to review and pull in this patch and the Kconfig update
after this patch(https://patchwork.ozlabs.org/patch/557389/)?  It
It's probably best for Boris to apply this now.
stated a dependency in the notes, but actually it should be applied
cleanly without that patch.  These patches are critical to make NAND
mtd feature work for our new chips.

Regards,
Leo

On Thu, Feb 18, 2016 at 6:07 PM, Scott Wood [off-list ref] wrote:
quoted
On Thu, 2016-02-18 at 15:18 -0600, Leo Li wrote:
quoted
On Wed, Feb 17, 2016 at 5:24 AM, Raghav Dogra [off-list ref] wrote:
quoted
The new IFC controller version 2.0 has a different memory map page.
Upto IFC 1.4 PAGE size is 4 KB and from IFC2.0 PAGE size is 64KB.
This patch segregates the IFC global and runtime registers to appropriate
PAGE sizes.

Signed-off-by: Jaiprakash Singh <redacted>
Signed-off-by: Raghav Dogra <redacted>
Acked-by: Li Yang <redacted>
Signed-off-by: Raghav Dogra <redacted>
---
Changes for v3: not dependent on
"drivers/memory: Add deep sleep support for IFC" patch

Changes for v2: rebased to resolve conflicts
Applicable to git://git.infradead.org/l2-mtd.git

This patch is dependent on "drivers/memory: Add deep sleep support for
IFC"
https://patchwork.ozlabs.org/patch/582762/
which is also applicable to git://git.infradead.org/l2-mtd.git
For the patch:

Acked-by: Brian Norris <computersforpeace@gmail.com>
quoted
quoted
This patch seems to be in good shape, but the dependency is still
having quite some feedback to be addressed.  Depending on it will
greatly delay the time that this critical patch for LS2 to be merged.
Could you remove the dependency like Scott already suggested?
According to the changelog the dependency has been removed (it would have been
clearer to remove this comment as well...).

-Scott


-- 
- Leo
Thread (17 messages) 17 messages, 7 authors, last reply 2016-06-29
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help