Thread (15 messages) flat view 15 messages, 3 authors, 2016-03-31

Re: [PATCH] Remove kretprobe_trampoline_holder.

From: Thiago Jung Bauermann <hidden>
Date: 2016-03-31 20:16:40

Am Donnerstag, 31 M=C3=A4rz 2016, 13:53:11 schrieb Naveen N. Rao:
You should indent the above output -- in this specific case, the star=
t
marker interferes with git am.
=20
Apart from that, I have tested this patch and kretprobe works fine. A=
minor nit I had is that we end up with a non-dot function in .text
without a corresponding function descriptor for kretprobe_trampoline.=
But, since this is a trampoline, I think that is good. So, for this
patch:
Reviewed-by: Naveen N. Rao <redacted>
Thanks for the tips and the review. I fixed the issue you mentioned and=
 sent=20
a new patch with your Reviewed-by.

Also thanks for fixing the vmlinux-kallsyms issue in ppc64le. I didn=E2=
=80=99t=20
comment on the patches because I=E2=80=99m not very familiar with the c=
ode in=20
question.

--=20
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help