Thread (43 messages) 43 messages, 4 authors, 2016-02-26

Re: [PATCH 06/12] powerpc/module: Rework is_early_mcount_callsite()

From: Balbir Singh <bsingharora@gmail.com>
Date: 2016-02-24 23:39:30
Also in: lkml

On 25/02/16 01:28, Michael Ellerman wrote:
is_early_mcount_callsite() needs to detect either the two instruction or
the three instruction versions of the _mcount() sequence.

But if we're running a kernel with the two instruction sequence, we need
to be careful not to read instruction - 2, otherwise we might fall off
the front of a page and cause an oops.

While we're here convert to bool to make the return semantics clear.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
 arch/powerpc/kernel/module_64.c | 30 ++++++++++++++----------------
 1 file changed, 14 insertions(+), 16 deletions(-)

Squash.
Do we even need to do this anymore?

Balbir Singh.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help