Re: [PATCH v8 6/6] cpufreq: powernv: Add sysfs attributes to show throttle stats
From: Viresh Kumar <viresh.kumar@linaro.org>
Date: 2016-02-03 14:06:07
Also in:
linux-api, linux-pm, lkml
From: Viresh Kumar <viresh.kumar@linaro.org>
Date: 2016-02-03 14:06:07
Also in:
linux-api, linux-pm, lkml
On 03-02-16, 17:32, Gautham R Shenoy wrote:
Regarding the table-format, it breaks the sysfs's one-value-per-file rule. So I would still prefer each throttle reason being a separate file which gives the number of times the chip frequency was throttled due to that reason. We can live without the per-frequency throttle stats listed in the throttle_status. So, would the following be sysfs group structure be acceptable? $ls -1 /sys/devices/system/cpu/cpuX/cpufreq/throttle_stats/ unthrottle powercap overtemp supply_fault overcurrent occ_reset turbo_stat sub_turbo_stat
That was suggested for your convenience only, feel free to keep it the way you want it. I forgot about the one-value-per-file thing really, but we are using that for cpufreq-stats as well. And now that you have mentioned that to me, why shouldn't this stats directory be moved to debugfs ? :) We are never going to perform a store here, isn't it ? And is just for information, nothing more. @Rafael: ?? -- viresh