Re: [PATCH v2 1/3] checkpatch.pl: add missing memory barriers

From
Joe Perches <joe@perches.com>
Date
2016-01-10 15:17:45
Also in
linux-arch, linux-arm-kernel, linux-mips, linux-s390, linux-sh, linux-um, lkml, sparclinux
Reply to
Joe Perches, 2016-01-10
On Sun, 2016-01-10 at 07:07 -0800, Joe Perches wrote:
On Sun, 2016-01-10 at 13:56 +0200, Michael S. Tsirkin wrote:
quoted
SMP-only barriers were missing in checkpatch.pl

Refactor code slightly to make adding more variants easier.
[]
quoted
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
If I use a variable called $smp_barriers, I'd expect
it to actually be the smp_barriers, not to have to
prefix it with smp_ before using it.

		my $smp_barriers = qr{
			smp_store_release|
			smp_load_acquire|
			smp_store_mb|
			smp_read_barrier_depends
That's missing (?:barriers) too.

btw: shouldn't this also have
	smp_mb__(?:before|after)_atomic
?
Thread (9 messages) 9 messages, 2 authors, last reply 2016-01-10
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help