Thread (68 messages) 68 messages, 4 authors, 2015-10-01

Re: [PATCH v4 27/32] cxlflash: Fix to prevent stale AFU RRQ

From: Daniel Axtens <hidden>
Date: 2015-09-30 23:51:32
Also in: linux-scsi

quoted
quoted
Following an adapter reset, the AFU RRQ that resides in host memory
holds stale data. This can lead to a condition where the RRQ interrupt
handler tries to process stale entries and/or endlessly loops due to an
out of sync generation bit.

To fix, the AFU RRQ in host memory needs to be cleared after each reset.
This looks good. Do you need anything to bail out of cxlflash_rrq_irq if
the data goes stale or to all Fs while that function is running?
We're not performing an MMIO here, so I'm not sure how the all Fs check
would apply. We're also protected fairly well by the generation bit. I suppose
we could look at adding some type of 'max iterations' count to protect against
a runaway handler but that would be in a future patch.
Ah, right you are. I had confused all Fs with UEs.

Reviewed-by: Daniel Axtens <redacted>

Regards,
Daniel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help