Thread (68 messages) 68 messages, 4 authors, 2015-10-01

Re: [PATCH v4 02/32] cxlflash: Replace magic numbers with literals

From: Andrew Donnellan <hidden>
Date: 2015-09-29 05:41:39
Also in: linux-scsi

On 26/09/15 09:12, Matthew R. Ochs wrote:
From: Manoj Kumar <redacted>

Magic numbers are not meaningful and can create confusion. As a
remedy, replace them with descriptive literals.

Replace 512 with literal MAX_SECTOR_UNIT.
Replace 5 with literal CMD_RETRIES.

Signed-off-by: Matthew R. Ochs <redacted>
Signed-off-by: Manoj N. Kumar <redacted>
Reviewed-by: Brian King <redacted>
Reviewed-by: Andrew Donnellan <redacted>

-- 
Andrew Donnellan              Software Engineer, OzLabs
andrew.donnellan@au1.ibm.com  Australia Development Lab, Canberra
+61 2 6201 8874 (work)        IBM Australia Limited
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help