Re: [PATCH v2 5/5] crypto: talitos: Add software backlog queue handling

On 3/6/2015 6:48 AM, Herbert Xu wrote:

On Thu, Mar 05, 2015 at 11:35:23AM +0200, Horia Geantă wrote:

quoted

quoted

Only potential problem is getting the crypto API to set the GFP_DMA
flag in the allocation request, but presumably a
CRYPTO_TFM_REQ_DMA crt_flag can be made to handle that.

Right. And this flag would apply only to request __ctx[].

Herbert, would this be an acceptable addition to crypto API?

How would such a flag work?

Hm, I thought that GFP_DMA memory could be allocated only for request
private ctx. This is obviously not the case.

*_request_alloc(tfm, gfp) crypto API functions would do:
if (crypto_tfm_get_flags(tfm) & CRYPTO_TFM_REQ_DMA)
        gfp |= GFP_DMA;

Thanks,
Horia